netdev - Re: [PATCH v2 -next] net/core/dev: Warn on a too-short GRO frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1459542570.6473.291.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Fri, 01 Apr 2016 13:29:30 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Aaron Conole <aconole@...heb.org>
Cc:	netdev@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2 -next] net/core/dev: Warn on a too-short GRO frame

On Fri, 2016-04-01 at 15:58 -0400, Aaron Conole wrote:
> From: Aaron Conole <aconole@...heb.org>
> 
> When signaling that a GRO frame is ready to be processed, the network stack
> correctly checks length and aborts processing when a frame is less than 14
> bytes. However, such a condition is really indicative of a broken driver,
> and should be loudly signaled, rather than silently dropped as the case is
> today.
> 
> Convert the condition to use net_warn_ratelimited() to ensure the stack
> loudly complains about such broken drivers.
> 
> Signed-off-by: Aaron Conole <aconole@...heb.org>
> ---


Shouldn't we give a hint of device name ?

(available in napi->dev->name )