netdev - Re: [PATCH] net: remove unimplemented RTNH_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56FFED8B.7010701@cogentembedded.com>
Date:	Sat, 2 Apr 2016 19:04:27 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Quentin Armitage <quentin@...itage.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: remove unimplemented RTNH_F_PERVASIVE

Hello.

On 4/2/2016 11:43 AM, Quentin Armitage wrote:

> Linux 2.1.68 introduced RTNH_F_PERVASIVE, but it had no implementation
> and couldn't be enabled since the required config parameter wasn't in
> any Kconfig file (see commit d088dde7b).

    scripts/checkpatch.pl now enforces certain commit citing format, your 
doesn't match it, i.e. you need 12-digit SHA1 and ("<commit summary") after that.

> This commit removes all remaining references to RTNH_F_PERVASIVE.
> Although this will cause userspace applications that were using the
> flag to fail to build, they will be alerted to the fact that using
> RTNH_F_PERVASIVE was not achieving anything.
>
> Signed-off-by: Quentin Armitage <quentin@...itage.org.uk>
[...]

> diff --git a/net/decnet/dn_fib.c b/net/decnet/dn_fib.c
> index df48034..f5660c6 100644
> --- a/net/decnet/dn_fib.c
> +++ b/net/decnet/dn_fib.c
> @@ -243,7 +243,7 @@ out:
>   	} else {
>   		struct net_device *dev;
>
> -		if (nh->nh_flags&(RTNH_F_PERVASIVE|RTNH_F_ONLINK))
> +		if (nh->nh_flags&RTNH_F_ONLINK)

    Please enclose & into spaces like below.

> diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
> index d97268e..3883860 100644
> --- a/net/ipv4/fib_semantics.c
> +++ b/net/ipv4/fib_semantics.c
> @@ -803,7 +803,7 @@ static int fib_check_nh(struct fib_config *cfg, struct fib_info *fi,
>   	} else {
>   		struct in_device *in_dev;
>
> -		if (nh->nh_flags & (RTNH_F_PERVASIVE | RTNH_F_ONLINK))
> +		if (nh->nh_flags & RTNH_F_ONLINK)
>   			return -EINVAL;
>
>   		rcu_read_lock();

MBR, Sergei