netdev - Re: [PATCH v2] rds: rds-stress show all zeros after few minutes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57014EA5.4080002@oracle.com>
Date:	Sun, 3 Apr 2016 10:11:01 -0700
From:	"santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:	Shamir Rabinovitch <shamir.rabinovitch@...cle.com>,
	David Miller <davem@...emloft.net>
Cc:	rds-devel@....oracle.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] rds: rds-stress show all zeros after few minutes

On 4/3/16 5:29 AM, Shamir Rabinovitch wrote:
> On Thu, Mar 31, 2016 at 04:02:46PM -0400, David Miller wrote:
>> From: shamir rabinovitch <shamir.rabinovitch@...cle.com>
>> Date: Thu, 31 Mar 2016 02:29:22 -0400
>>
>>> Issue can be seen on platforms that use 8K and above page size
>>> while rds fragment size is 4K. On those platforms single page is
>>> shared between 2 or more rds fragments. Each fragment has its own
>>> offset and rds congestion map code need to take this offset to account.
>>> Not taking this offset to account lead to reading the data fragment
>>> as congestion map fragment and hang of the rds transmit due to far
>>> congestion map corruption.
>>>
>>> Signed-off-by: shamir rabinovitch <shamir.rabinovitch@...cle.com>
>>>
>>> Reviewed-by: Wengang Wang <wen.gang.wang@...cle.com>
>>> Reviewed-by: Ajaykumar Hotchandani <ajaykumar.hotchandani@...cle.com>
>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>
>>> Tested-by: Anand Bibhuti <anand.bibhuti@...cle.com>
>>
>> This doesn't apply cleanly to my current tree, please respin.
>
> Sorry for the trouble.
>
> Re-sent the patch based on net-next master.
> Broke the patch according to comments from Santosh Shilimkar.
>
Thanks Shamir. Updated versions looks fine. You already
have my ack included.


Regards,
Santosh