[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 4 Apr 2016 16:16:45 -0400
From: Bastien Philbert <bastienphilbert@...il.com>
To: David Miller <davem@...emloft.net>
Cc: stephen@...workplumber.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bridge:Fix incorrect variable assignment on error path in
br_sysfs_addbr
On 2016-04-04 04:14 PM, David Miller wrote:
> From: Bastien Philbert <bastienphilbert@...il.com>
> Date: Sun, 3 Apr 2016 19:04:26 -0400
>
>> This fixes the incorrect variable assignment on error path in
>> br_sysfs_addbr for when the call to kobject_create_and_add
>> fails to assign the value of -EINVAL to the returned variable of
>> err rather then incorrectly return zero making callers think this
>> function has succeededed due to the previous assignment being
>> assigned zero when assigning it the successful return value of
>> the call to sysfs_create_group which is zero.
>>
>> Signed-off-by: Bastien Philbert <bastienphilbert@...il.com>
>
> Applied, but please put a space after the subsystem prefix and the
> colon character in your subject lines in the future.
>
> Doesn't that really look odd to you, the way you did it? "net:Fix"?
>
> Doesn't it look more natural, and consistent with what all other
> patch submitters do, if it's "net: Fix"?
>
> Thanks.
>
Done, sorry about that :(. Will remember for future patches.
Bastien
Powered by blists - more mailing lists