netdev - Re: [PATCH net-next 05/10] bnxt_en: Add get_eee() and set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1459891365.24442.4.camel@decadent.org.uk>
Date:	Tue, 05 Apr 2016 22:22:45 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Michael Chan <michael.chan@...adcom.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 05/10] bnxt_en: Add get_eee() and set_eee()
 ethtool support.

On Tue, 2016-04-05 at 03:36 -0700, Michael Chan wrote:
> On Tue, Apr 5, 2016 at 3:07 AM, Ben Hutchings <ben@...adent.org.uk> wrote:
[...]
> > > +static int bnxt_get_eee(struct net_device *dev, struct ethtool_eee *edata)
> > > +{
> > > +     struct bnxt *bp = netdev_priv(dev);
> > > +
> > > +     if (!(bp->flags & BNXT_FLAG_EEE_CAP))
> > > +             return -EOPNOTSUPP;
> > > +
> > > +     *edata = bp->eee;
> > > +     if (!bp->eee.eee_enabled) {
> > > +             edata->advertised = 0;
> > > +             edata->tx_lpi_enabled = 0;
> > What about tx_lpi_timer?
> We want to keep the tx_lpi_timer value so that it can be used again
> when it is turned on again.
> 
> The user doesn't have to figure out what value to use if he just wants
> to use the default or the last value.

OK, that seems like a good reason.

> > 
> > 
> > And, wouldn't it make more sense to do these fixups to the internal
> > state in bnxt_set_eee()?
> I don't understand.  If the user is enabling EEE, we take all the
> parameters.  If he is disabling, we don't take any of the parameters.

Right - it's just a bit weird that you keep the internal state in a
struct ethtool_eee but get_eee() returns a slightly different version
of the state.

Ben.

-- 
Ben Hutchings
No political challenge can be met by shopping. - George Monbiot
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)