netdev - Re: [PATCH v2] net: remove unimplemented RTNH_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160405.195759.110758435613250333.davem@davemloft.net>
Date:	Tue, 05 Apr 2016 19:57:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	quentin@...itage.org.uk
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: remove unimplemented RTNH_F_PERVASIVE

From: Quentin Armitage <quentin@...itage.org.uk>
Date: Sat,  2 Apr 2016 17:51:28 +0100

> Linux 2.1.68 introduced RTNH_F_PERVASIVE, but it had no implementation
> and couldn't be enabled since the required config parameter wasn't in
> any Kconfig file (see commit d088dde7b196 ("ipv4: obsolete config in
> kernel source (IP_ROUTE_PERVASIVE)")).
> 
> This commit removes all remaining references to RTNH_F_PERVASIVE.
> Although this will cause userspace applications that were using the
> flag to fail to build, they will be alerted to the fact that using
> RTNH_F_PERVASIVE was not achieving anything.
> 
> Signed-off-by: Quentin Armitage <quentin@...itage.org.uk>

Can't really delete values like this from user visible headers.  It
can break the build.

What if some library or tool has a table translating RTNH_F_* values
into strings to display to the user?  Those sources will stop building
if I apply your changes.