netdev - Re: [net-next 08/14] ixgbe: Add support for generic Tx checksums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160404.212739.417828551756386273.davem@davemloft.net>
Date:	Mon, 04 Apr 2016 21:27:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sridhar.samudrala@...el.com
Cc:	jeffrey.t.kirsher@...el.com, aduyck@...antis.com,
	netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
	jogreene@...hat.com
Subject: Re: [net-next 08/14] ixgbe: Add support for generic Tx checksums

From: "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
Date: Mon, 04 Apr 2016 15:32:37 -0700

> On 4/4/2016 3:14 PM, Jeff Kirsher wrote:
>> @@ -9190,41 +9148,37 @@ skip_sriov:
>>     #endif
>>   	netdev->features = NETIF_F_SG |
>> -			   NETIF_F_IP_CSUM |
>> -			   NETIF_F_IPV6_CSUM |
>> -			   NETIF_F_HW_VLAN_CTAG_TX |
>> -			   NETIF_F_HW_VLAN_CTAG_RX |
>>   			   NETIF_F_TSO |
>>   			   NETIF_F_TSO6 |
>>   			   NETIF_F_RXHASH |
>> -			   NETIF_F_RXCSUM;
>> -
>> -	netdev->hw_features = netdev->features | NETIF_F_HW_L2FW_DOFFLOAD;
>> +			   NETIF_F_RXCSUM |
>> +			   NETIF_F_HW_CSUM |
>> +			   NETIF_F_SCTP_CRC |
>> +			   NETIF_F_HW_VLAN_CTAG_TX |
>> +			   NETIF_F_HW_VLAN_CTAG_RX;
>>   -	switch (adapter->hw.mac.type) {
>> -	case ixgbe_mac_82599EB:
>> -	case ixgbe_mac_X540:
>> -	case ixgbe_mac_X550:
>> -	case ixgbe_mac_X550EM_x:
>> +	if (hw->mac.type >= ixgbe_mac_82599EB)
>>   		netdev->features |= NETIF_F_SCTP_CRC;
>> -		netdev->hw_features |= NETIF_F_SCTP_CRC |
>> -				       NETIF_F_NTUPLE |
>> -				       NETIF_F_HW_TC;
>> -		break;
>> -	default:
>> -		break;
>> -	}
>>   -	netdev->hw_features |= NETIF_F_RXALL;
>> +	/* copy netdev features into list of user selectable features */
>> +	netdev->hw_features |= netdev->features;
>> +	netdev->hw_features |= NETIF_F_RXALL |
>> +			       NETIF_F_HW_L2FW_DOFFLOAD;
>> +
>> +	if (hw->mac.type >= ixgbe_mac_82599EB)
>> +		netdev->hw_features |= NETIF_F_NTUPLE;
> 
> looks like the cleanup missed moving NETIF_F_HW_TC flag here that
> enables cls_u32 offloads via TC.

Indeed, this is a regression.