netdev - Re: [PATCH (net.git)] stmmac: fix adjust link call in case of a switch is attached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160406.163503.481176843308939572.davem@davemloft.net>
Date:	Wed, 06 Apr 2016 16:35:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, alexandre.torgue@...com
Subject: Re: [PATCH (net.git)] stmmac: fix adjust link call in case of a
 switch is attached

From: Giuseppe Cavallaro <peppe.cavallaro@...com>
Date: Tue, 5 Apr 2016 08:46:57 +0200

> While initializing the phy, the stmmac driver sets the
> PHY_IGNORE_INTERRUPT so the PAL won't call the adjust hook
> that is needed, on some platforms, e.g. STi, to invoke the glue.
> 
> The patch allows the PAL to poll the stmmac_adjust_link just one time
> in case of a switch is attached, setting later the PHY_IGNORE_INTERRUPT
> flag.
> Moving this kind of logic inside the adjust_link it makes sense to
> anticipate the check for EEE that will never initialized in this
> scenario.
> 
> Reported-by: Gabriel Fernandez <gabriel.fernandez@...aro.org>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Tested-by: Gabriel Fernandez <gabriel.fernandez@...aro.org>
> Cc: Alexandre TORGUE <alexandre.torgue@...com>

Applied, thank you.