lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Apr 2016 09:10:30 +0000 From: Fugang Duan <fugang.duan@....com> To: Troy Kisky <troy.kisky@...ndarydevices.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>, "lznuaa@...il.com" <lznuaa@...il.com> CC: Fabio Estevam <fabio.estevam@....com>, "l.stach@...gutronix.de" <l.stach@...gutronix.de>, "andrew@...n.ch" <andrew@...n.ch>, "tremyfr@...il.com" <tremyfr@...il.com>, "gerg@...inux.org" <gerg@...inux.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "johannes@...solutions.net" <johannes@...solutions.net>, "stillcompiling@...il.com" <stillcompiling@...il.com>, "sergei.shtylyov@...entembedded.com" <sergei.shtylyov@...entembedded.com>, "arnd@...db.de" <arnd@...db.de> Subject: RE: [PATCH net-next V3 02/16] net: fec: remove unused interrupt FEC_ENET_TS_TIMER From: Troy Kisky <troy.kisky@...ndarydevices.com> Sent: Wednesday, April 06, 2016 10:26 AM > To: netdev@...r.kernel.org; davem@...emloft.net; Fugang Duan > <fugang.duan@....com>; lznuaa@...il.com > Cc: Fabio Estevam <fabio.estevam@....com>; l.stach@...gutronix.de; > andrew@...n.ch; tremyfr@...il.com; gerg@...inux.org; linux-arm- > kernel@...ts.infradead.org; johannes@...solutions.net; > stillcompiling@...il.com; sergei.shtylyov@...entembedded.com; > arnd@...db.de; Troy Kisky <troy.kisky@...ndarydevices.com> > Subject: [PATCH net-next V3 02/16] net: fec: remove unused interrupt > FEC_ENET_TS_TIMER > > FEC_ENET_TS_TIMER is not checked in the interrupt routine so there is no need > to enable it. > > Signed-off-by: Troy Kisky <troy.kisky@...ndarydevices.com> > > --- > v3: New patch > > Frank Li said "TS_TIMER should never be triggered." > when discussing another patch. > --- > drivers/net/ethernet/freescale/fec.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fec.h > b/drivers/net/ethernet/freescale/fec.h > index 195122e..6dd0ba8 100644 > --- a/drivers/net/ethernet/freescale/fec.h > +++ b/drivers/net/ethernet/freescale/fec.h > @@ -374,8 +374,8 @@ struct bufdesc_ex { > #define FEC_ENET_TS_AVAIL ((uint)0x00010000) > #define FEC_ENET_TS_TIMER ((uint)0x00008000) > > -#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII > | FEC_ENET_TS_TIMER) > -#define FEC_NAPI_IMASK (FEC_ENET_MII | FEC_ENET_TS_TIMER) > +#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII) > +#define FEC_NAPI_IMASK FEC_ENET_MII > #define FEC_RX_DISABLED_IMASK (FEC_DEFAULT_IMASK & (~FEC_ENET_RXF)) > > /* ENET interrupt coalescing macro define */ > -- > 2.5.0 Acked-by: Fugang Duan <fugang.duan@....com>
Powered by blists - more mailing lists