netdev - Re: [PATCH net-next] tcp/dccp: fix inet_reuseport_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160407.120256.283752166035245785.davem@davemloft.net>
Date:	Thu, 07 Apr 2016 12:02:56 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	dsa@...ulusnetworks.com, netdev@...r.kernel.org,
	edumazet@...gle.com
Subject: Re: [PATCH net-next] tcp/dccp: fix inet_reuseport_add_sock()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 06 Apr 2016 22:07:34 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> David Ahern reported panics in __inet_hash() caused by my recent commit.
> 
> The reason is inet_reuseport_add_sock() was still using
> sk_nulls_for_each_rcu() instead of sk_for_each_rcu().
> SO_REUSEPORT enabled listeners were causing an instant crash.
> 
> While chasing this bug, I found that I forgot to clear SOCK_RCU_FREE
> flag, as it is inherited from the parent at clone time.
> 
> Fixes: 3b24d854cb35 ("tcp/dccp: do not touch listener sk_refcnt under synflood")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: David Ahern <dsa@...ulusnetworks.com>

Applied, thanks Eric.