netdev - Re: [net PATCH v3] GRE: Disable segmentation offloads w/ CSUM and we are encapsulated via FOU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160407.165711.46922408670633362.davem@davemloft.net>
Date:	Thu, 07 Apr 2016 16:57:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	aduyck@...antis.com
Cc:	jesse@...nel.org, netdev@...r.kernel.org,
	alexander.duyck@...il.com, tom@...bertland.com
Subject: Re: [net PATCH v3] GRE: Disable segmentation offloads w/ CSUM and
 we are encapsulated via FOU

From: Alexander Duyck <aduyck@...antis.com>
Date: Tue, 05 Apr 2016 09:13:39 -0700

> This patch fixes an issue I found in which we were dropping frames if we
> had enabled checksums on GRE headers that were encapsulated by either FOU
> or GUE.  Without this patch I was barely able to get 1 Gb/s of throughput.
> With this patch applied I am now at least getting around 6 Gb/s.
> 
> The issue is due to the fact that with FOU or GUE applied we do not provide
> a transport offset pointing to the GRE header, nor do we offload it in
> software as the GRE header is completely skipped by GSO and treated like a
> VXLAN or GENEVE type header.  As such we need to prevent the stack from
> generating it and also prevent GRE from generating it via any interface we
> create.
> 
> Fixes: c3483384ee511 ("gro: Allow tunnel stacking in the case of FOU/GUE")
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>
> ---
> 
> v3: Basically the same patch as v1 and v2, but I am cutting it loose from
>     the IPv4 ID patch as that one will likely need to be resolved in
>     net-next.

Applied, thanks Alexander.