netdev - Re: [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_cc3a8g-8AVEK4GuQXhq9zUgJh72vq3MARiDYNN-2B-qw@mail.gmail.com>
Date:	Thu, 7 Apr 2016 11:49:23 +0800
From:	Xin Long <lucien.xin@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	makita.toshiaki@....ntt.co.jp,
	network dev <netdev@...r.kernel.org>,
	bridge@...ts.linux-foundation.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by
 calling store_bridge_parm

On Thu, Apr 7, 2016 at 4:10 AM, David Miller <davem@...emloft.net> wrote:
> From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> Date: Tue, 5 Apr 2016 14:08:13 +0900
>
>> On 2016/04/05 12:32, Xin Long wrote:
>>> There are some repetitive codes in stp_state_store, we can remove
>>> them by calling store_bridge_parm.
>>>
>>> Signed-off-by: Xin Long <lucien.xin@...il.com>
>>> ---
>>>  net/bridge/br_sysfs_br.c | 24 +++++++-----------------
>>>  1 file changed, 7 insertions(+), 17 deletions(-)
>>>
>>> diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
>>> index 137cd3b..9918763 100644
>>> --- a/net/bridge/br_sysfs_br.c
>>> +++ b/net/bridge/br_sysfs_br.c
>>> @@ -128,27 +128,17 @@ static ssize_t stp_state_show(struct device *d,
>>>  }
>>>
>>>
>>> +static int set_stp_state(struct net_bridge *br, unsigned long val)
>>> +{
>>
>> You forgot to add rtnl lock here?
>> The missing lock is restored in patch 4, but at this point bisect could
>> break..
OK, if I will fix this, if there's no other issues on this patchset,
I will post v3 later.
Thanks.

>
> Agreed, this has to be fixed.