netdev - Re: [PATCH v2] packet: uses kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160408162723.GA23549@jwg>
Date:	Fri, 8 Apr 2016 09:27:25 -0700
From:	Weongyo Jeong <weongyo.linux@...il.com>
To:	Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:	Network Development <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH v2] packet: uses kfree_skb() for drops or errors.

On Thu, Apr 07, 2016 at 12:06:12PM -0400, Willem de Bruijn wrote:
> On Wed, Apr 6, 2016 at 5:14 PM, Weongyo Jeong <weongyo.linux@...il.com> wrote:
> > consume_skb() isn't for drop or error cases
> 
> for drop or error -> for error
> 
> > that  kfree_skb() is more proper
> > one.  At this patch, it fixed tpacket_rcv() and packet_rcv() to be
> > consistent for error or non-error cases letting perf trace its event
> > properly.
> >
> > Signed-off-by: Weongyo Jeong <weongyo.linux@...il.com>
> 
> Don't forget to add the target to your subject line: PATCH net-next v3.
> 
> > ---
> >  net/packet/af_packet.c | 16 ++++++++++++----
> >  1 file changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> > index 1ecfa71..cd100cf 100644
> > --- a/net/packet/af_packet.c
> > +++ b/net/packet/af_packet.c
> > @@ -2040,7 +2040,7 @@ static int packet_rcv(struct sk_buff *skb, struct net_device *dev,
> >         struct sockaddr_ll *sll;
> >         struct packet_sock *po;
> >         u8 *skb_head = skb->data;
> > -       int skb_len = skb->len;
> > +       int err = 0, skb_len = skb->len;
> 
> bool
> 
> Otherwise looks good.

Thank you for review Willem. I just had submitted v3 version.

Regards,
Weongyo Jeong