netdev - Re: [PATCH net] ipv6: Count in extension headers in skb->network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160407.224455.695892175098979019.davem@davemloft.net>
Date:	Thu, 07 Apr 2016 22:44:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jkbs@...hat.com
Cc:	netdev@...r.kernel.org, jiji@...hat.com, hannes@...essinduktion.org
Subject: Re: [PATCH net] ipv6: Count in extension headers in
 skb->network_header

From: Jakub Sitnicki <jkbs@...hat.com>
Date: Tue,  5 Apr 2016 18:41:08 +0200

> When sending a UDPv6 message longer than MTU, account for the length
> of fragmentable IPv6 extension headers in skb->network_header offset.
> Same as we do in alloc_new_skb path in __ip6_append_data().
> 
> This ensures that later on __ip6_make_skb() will make space in
> headroom for fragmentable extension headers:
> 
> 	/* move skb->data to ip header from ext header */
> 	if (skb->data < skb_network_header(skb))
> 		__skb_pull(skb, skb_network_offset(skb));
> 
> Prevents a splat due to skb_under_panic:
 ...
> Reported-by: Ji Jianwen <jiji@...hat.com>
> Signed-off-by: Jakub Sitnicki <jkbs@...hat.com>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied and queued up for -stable, thanks.