netdev - Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160408.165100.1546798904754346458.davem@davemloft.net>
Date:	Fri, 08 Apr 2016 16:51:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vivien.didelot@...oirfairelinux.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...oirfairelinux.com, andrew@...n.ch, f.fainelli@...il.com,
	jiri@...nulli.us, sfeldma@...il.com
Subject: Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and
 FDB/VLAN add ops

From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Date: Wed,  6 Apr 2016 11:55:02 -0400

> Neither the DSA layer nor the bridge code (see br_set_state) really care
> about eventual errors from STP state setters, so make it void.
> 
> The DSA layer separates the prepare and commit phases of switchdev in
> two different functions. Logical errors must not happen in commit
> routines, so make them void.
> 
> Changes v1 -> v2:
>   - rename port_stp_update to port_stp_state_set
>   - don't change code flow of bcm_sf2_sw_br_set_stp_state
>   - prefer netdev_err over netdev_warn

Series applied.