netdev - [PATCH RESEND] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1460114922-4148-1-git-send-email-wsa@the-dreams.de>
Date:	Fri,  8 Apr 2016 13:28:42 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	netdev@...r.kernel.org
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	linux-renesas-soc@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Subject: [PATCH RESEND] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0

From: Wolfram Sang <wsa+renesas@...g-engineering.com>

The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.

Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
---

The original patch was marked as "NOT APPLICABLE" in patchwork. I reviewed
again and can't see why. So, in case this remains true, please explain.

 drivers/net/ethernet/renesas/ravb_main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 4e1a7dba7c4abb..791930b63991dc 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1691,6 +1691,9 @@ static int ravb_set_gti(struct net_device *ndev)
 	rate = clk_get_rate(clk);
 	clk_put(clk);
 
+	if (!rate)
+		return -EINVAL;
+
 	inc = 1000000000ULL << 20;
 	do_div(inc, rate);
 
-- 
2.7.0