netdev - Re: [PATCH net-next] net: bcmgenet: use napi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B66FA2B-6AAE-4FEB-B5FB-C5C9DF48FDB5@gmail.com>
Date:	Fri, 08 Apr 2016 22:19:25 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>
CC:	netdev <netdev@...r.kernel.org>,
	Petri Gynther <pgynther@...gle.com>, opendmb@...il.com
Subject: Re: [PATCH net-next] net: bcmgenet: use napi_complete_done()

On April 8, 2016 10:06:40 PM PDT, Eric Dumazet <eric.dumazet@...il.com> wrote:
>From: Eric Dumazet <edumazet@...gle.com>
>
>By using napi_complete_done(), we allow fine tuning
>of /sys/class/net/ethX/gro_flush_timeout for higher GRO aggregation
>efficiency for a Gbit NIC.
>
>Check commit 24d2e4a50737 ("tg3: use napi_complete_done()") for
>details.
>
>Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>Cc: Petri Gynther <pgynther@...gle.com>
>Cc: Florian Fainelli <f.fainelli@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Along the same line of changes, we could use napi_schedule_irqoff since NAPI is always scheduled from ISR context.


>---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
>b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
>index f7b42b9fc979..e823013d3125 100644
>--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
>+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
>@@ -1735,7 +1735,7 @@ static int bcmgenet_rx_poll(struct napi_struct
>*napi, int budget)
> 	work_done = bcmgenet_desc_rx(ring, budget);
> 
> 	if (work_done < budget) {
>-		napi_complete(napi);
>+		napi_complete_done(napi, work_done);
> 		ring->int_enable(ring);
> 	}
> 


-- 
Florian