lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGXr9JE8Qp-u4gjm08oB8nXDoQxFM12=Da2=MZbWcZrRXOCi_w@mail.gmail.com> Date: Fri, 8 Apr 2016 18:39:55 -0700 From: Petri Gynther <pgynther@...gle.com> To: David Miller <davem@...emloft.net>, Eric Dumazet <eric.dumazet@...il.com> Cc: netdev <netdev@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com>, opendmb@...il.com, Jaedon Shin <jaedon.shin@...il.com> Subject: Re: [PATCH net-next] net: bcmgenet: add BQL support On Fri, Apr 8, 2016 at 1:36 PM, David Miller <davem@...emloft.net> wrote: > From: Petri Gynther <pgynther@...gle.com> > Date: Tue, 5 Apr 2016 17:50:01 -0700 > >> Add Byte Queue Limits (BQL) support to bcmgenet driver. >> >> Signed-off-by: Petri Gynther <pgynther@...gle.com> > > As Eric Dumazet indicated, your ->ndo_init() code to reset the queues is > probably not necessary at all. I added the netdev_tx_reset_queue(txq) calls to ndo_open() path: netdev->ndo_open() bcmgenet_open() bcmgenet_netif_start() for all Tx queues: netdev_tx_reset_queue(txq) clear __QUEUE_STATE_STACK_XOFF dql_reset() netif_tx_start_all_queues(dev) for all Tx queues: clear __QUEUE_STATE_DRV_XOFF So, I think the call to netdev_tx_reset_queue(txq) is in the right place. It ensures that the Tx queue state is clean when the device is opened.
Powered by blists - more mailing lists