lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5708FBBC.7000106@cumulusnetworks.com> Date: Sat, 9 Apr 2016 14:55:24 +0200 From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com> To: Xin Long <lucien.xin@...il.com>, network dev <netdev@...r.kernel.org>, bridge@...ts.linux-foundation.org Cc: davem@...emloft.net, Stephen Hemminger <stephen@...workplumber.org> Subject: Re: [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl On 04/08/2016 06:03 PM, Xin Long wrote: > This patchset is used to support sending rntl info to user in some places, > and ensure that whenever those attributes change internally or from sysfs, > that a netlink notification is sent out to listeners. > > It also make some adjustment in bridge sysfs so that we can implement this > easily. > > I've done some tests on this patchset, like: > [br_sysfs] > 1. change all the attribute values of br or brif: > $ echo $value > /sys/class/net/br0/bridge/{*} > $ echo $value > /sys/class/net/br0/brif/eth1/{*} > > 2. meanwhile, on another terminal to observe the msg: > $ bridge monitor > > [br_ioctl] > 1. in bridge-utils package, do some changes in br_set, let brctl command > use ioctl to set attribute: > if ((ret = set_sysfs(path, value)) < 0) { --> > if (1) { > > $ brctl set* > > 2. meanwhile, on another terminal to observe the msg: > $ bridge monitor > > This test covers all the attributes that brctl and sysfs support to set. > Overall the set looks good to me, just one comment for future posts - please include the changes between versions of the set in your cover letter and individual patches. I had to go back to your previous postings and read my own comments and compare them with this set. Thank you, Nik
Powered by blists - more mailing lists