netdev - Re: [PATCH net-next 3/6] qed/qede: Add VXLAN tunnel slowpath configuration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEh+42g4+=UT95B5gyW4RZ+yqKAABxaE4SoDEA2f6OKiUSNGcA@mail.gmail.com>
Date:	Sat, 9 Apr 2016 13:29:38 -0300
From:	Jesse Gross <jesse@...nel.org>
To:	Manish Chopra <manish.chopra@...gic.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Ariel.Elior@...gic.com, Yuval.Mintz@...gic.com
Subject: Re: [PATCH net-next 3/6] qed/qede: Add VXLAN tunnel slowpath
 configuration support

On Sat, Apr 9, 2016 at 10:17 AM, Manish Chopra <manish.chopra@...gic.com> wrote:
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
> index 518af32..9a82d42 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_main.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
[...]
> +static netdev_features_t qede_features_check(struct sk_buff *skb,
> +                                            struct net_device *dev,
> +                                            netdev_features_t features)
> +{
> +       return vxlan_features_check(skb, features);
> +}

This is going to restrict the set of protocols that can be offloaded
to those that look exactly like VXLAN. In particular, it means that
you won't be able offload Geneve with options. I don't think this what
you mean to do given that you are supporting these protocols in the
other patches and I know this hardware has more capabilities than just
VXLAN. I think that you want to do a header length check - similar to
what the Intel drivers are doing for example.

I noticed that the bnx2x driver has a similar issue as well.