netdev - Re: [PATCH net-next] net: bcmgenet: use __napi_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXr9JHkrP=AGcJJVoSHcty4sWj-asKSjjd5G4wAhaFjLKoBbA@mail.gmail.com>
Date:	Sat, 9 Apr 2016 10:24:20 -0700
From:	Petri Gynther <pgynther@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, opendmb@...il.com
Subject: Re: [PATCH net-next] net: bcmgenet: use __napi_schedule_irqoff()

On Fri, Apr 8, 2016 at 10:30 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Florian Fainelli <f.fainelli@...il.com>
>
> bcmgenet_isr1() and bcmgenet_isr0() run in hard irq context,
> we do not need to block irq again.
>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Petri Gynther <pgynther@...gle.com>

> ---
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index f7b42b9fc979..4367d561a12e 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -2493,7 +2493,7 @@ static irqreturn_t bcmgenet_isr1(int irq, void *dev_id)
>
>                 if (likely(napi_schedule_prep(&rx_ring->napi))) {
>                         rx_ring->int_disable(rx_ring);
> -                       __napi_schedule(&rx_ring->napi);
> +                       __napi_schedule_irqoff(&rx_ring->napi);
>                 }
>         }
>
> @@ -2506,7 +2506,7 @@ static irqreturn_t bcmgenet_isr1(int irq, void *dev_id)
>
>                 if (likely(napi_schedule_prep(&tx_ring->napi))) {
>                         tx_ring->int_disable(tx_ring);
> -                       __napi_schedule(&tx_ring->napi);
> +                       __napi_schedule_irqoff(&tx_ring->napi);
>                 }
>         }
>
> @@ -2536,7 +2536,7 @@ static irqreturn_t bcmgenet_isr0(int irq, void *dev_id)
>
>                 if (likely(napi_schedule_prep(&rx_ring->napi))) {
>                         rx_ring->int_disable(rx_ring);
> -                       __napi_schedule(&rx_ring->napi);
> +                       __napi_schedule_irqoff(&rx_ring->napi);
>                 }
>         }
>
> @@ -2545,7 +2545,7 @@ static irqreturn_t bcmgenet_isr0(int irq, void *dev_id)
>
>                 if (likely(napi_schedule_prep(&tx_ring->napi))) {
>                         tx_ring->int_disable(tx_ring);
> -                       __napi_schedule(&tx_ring->napi);
> +                       __napi_schedule_irqoff(&tx_ring->napi);
>                 }
>         }
>
>
>