netdev - Re: [PATCH net-next 0/2] fix udp pull header breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160411.153156.115903140123859564.davem@davemloft.net>
Date:	Mon, 11 Apr 2016 15:31:56 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	willemdebruijn.kernel@...il.com
Cc:	netdev@...r.kernel.org, fcooper@...com, samanthakumar@...gle.com,
	willemb@...gle.com
Subject: Re: [PATCH net-next 0/2] fix udp pull header breakage

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Thu,  7 Apr 2016 11:44:57 -0400

> Commit e6afc8ace6dd ("udp: remove headers from UDP packets before
> queueing") modified udp receive processing to pull headers before
> enqueue and to not expect them on dequeue.
> 
> The patch missed protocols on top of udp with in-kernel
> implementations that have their own skb_recv_datagram calls and
> dequeue logic. Modify these datapaths to also no longer expect
> a udp header at skb->data.
> 
> Sunrpc and rxrpc are the only two protocols that call this
> function and contain references to udphr (some others, like tipc,
> are based on encap_rcv, which acts before enqueue, before the
> the header pull).

Series applied, thanks for fixing this regression so quickly.