netdev - Re: [PATCH v4] route: do not cache fib route info on local routes with oif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160413.233400.893479949245860952.davem@davemloft.net>
Date:	Wed, 13 Apr 2016 23:34:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	chris.friesen@...driver.com
Cc:	ja@....bg, netdev@...r.kernel.org
Subject: Re: [PATCH v4] route: do not cache fib route info on local routes
 with oif

From: Chris Friesen <chris.friesen@...driver.com>
Date: Fri, 8 Apr 2016 15:21:30 -0600

> For local routes that require a particular output interface we do not want
> to cache the result.  Caching the result causes incorrect behaviour when
> there are multiple source addresses on the interface.  The end result
> being that if the intended recipient is waiting on that interface for the
> packet he won't receive it because it will be delivered on the loopback
> interface and the IP_PKTINFO ipi_ifindex will be set to the loopback
> interface as well.
> 
> This can be tested by running a program such as "dhcp_release" which
> attempts to inject a packet on a particular interface so that it is
> received by another program on the same board.  The receiving process
> should see an IP_PKTINFO ipi_ifndex value of the source interface
> (e.g., eth1) instead of the loopback interface (e.g., lo).  The packet
> will still appear on the loopback interface in tcpdump but the important
> aspect is that the CMSG info is correct.
> 
> Sample dhcp_release command line:
> 
>    dhcp_release eth1 192.168.204.222 02:11:33:22:44:66
> 
> Signed-off-by: Allain Legacy <allain.legacy@...driver.com>
> Signed off-by: Chris Friesen <chris.friesen@...driver.com>

Applied and queued up for -stable, thanks.