netdev - Re: [PATCH net] packet: fix heap info leak in PACKET_DIAG_MCLIST sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160414.004724.860240909570915881.davem@davemloft.net>
Date:	Thu, 14 Apr 2016 00:47:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	minipli@...glemail.com
Cc:	netdev@...r.kernel.org, ebiederm@...ssion.com, xemul@...allels.com
Subject: Re: [PATCH net] packet: fix heap info leak in PACKET_DIAG_MCLIST
 sock_diag interface

From: Mathias Krause <minipli@...glemail.com>
Date: Sun, 10 Apr 2016 12:52:28 +0200

> Because we miss to wipe the remainder of i->addr[] in packet_mc_add(),
> pdiag_put_mclist() leaks uninitialized heap bytes via the
> PACKET_DIAG_MCLIST netlink attribute.
> 
> Fix this by explicitly memset(0)ing the remaining bytes in i->addr[].
> 
> Fixes: eea68e2f1a00 ("packet: Report socket mclist info via diag module")
> Signed-off-by: Mathias Krause <minipli@...glemail.com>

Applied and queued up for -stable, thanks.