netdev - Re: [PATCH net v3] net: sched: do not requeue a NULL skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160414.012930.746981483324064373.davem@davemloft.net>
Date:	Thu, 14 Apr 2016 01:29:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	lars.persson@...s.com
Cc:	netdev@...r.kernel.org, jhs@...atatu.com,
	linux-kernel@...r.kernel.org, xiyou.wangcong@...il.com,
	eric.dumazet@...il.com, larper@...s.com
Subject: Re: [PATCH net v3] net: sched: do not requeue a NULL skb

From: Lars Persson <lars.persson@...s.com>
Date: Tue, 12 Apr 2016 08:45:52 +0200

> A failure in validate_xmit_skb_list() triggered an unconditional call
> to dev_requeue_skb with skb=NULL. This slowly grows the queue
> discipline's qlen count until all traffic through the queue stops.
> 
> We take the optimistic approach and continue running the queue after a
> failure since it is unknown if later packets also will fail in the
> validate path.
> 
> Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock")
> Signed-off-by: Lars Persson <larper@...s.com>

Applied and queued up for -stable, thanks.