netdev - Re: [PATCHv3 net-next 1/6] sctp: add sctp_info dump api for sctp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Apr 2016 11:13:18 +0200
From:	Phil Sutter <phil@....cc>
To:	Xin Long <lucien.xin@...il.com>
Cc:	network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	Vlad Yasevich <vyasevich@...il.com>, daniel@...earbox.net,
	davem@...emloft.net, eric.dumazet@...il.com
Subject: Re: [PATCHv3 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

Hi Xin Long,

On Thu, Apr 14, 2016 at 03:35:30PM +0800, Xin Long wrote:
> sctp_diag will dump some important details of sctp's assoc or ep, we use
> sctp_info to describe them,  sctp_get_sctp_info to get them, and export
> it to sctp_diag.ko.
> 
> v2->v3:
> - we will not use list_for_each_safe in sctp_get_sctp_info, cause
>   all the callers of it will use lock_sock.
> 
> - fix the holes in struct sctp_info with __reserved* field.
>   because sctp_diag is a new feature, and sctp_info is just for now,
>   it may be changed in the future.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

You're mixing commit message and changelog here (and in the following
patches, too). In order to not make the changelog part of the commit
message, you should separate it with three dashes, just like
git-format-patch does with the diff stat. So please reformat the patches
to meet this pattern:

------------------8<--------------------
Commit message here

Signed-off-by
---
Changelog here
---
diff stat added by Git

diff --git a/foo/bar.c b/foo/bar.c
...
------------------8<--------------------

If you think some of the changelog's info should be preserved, better
integrate it into the message itself.

Cheers, Phil