netdev - Re: [PATCH net-next v2 1/7] net: dsa: mv88e6xxx: drop double ds assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Apr 2016 01:39:17 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...oirfairelinux.com,
	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next v2 1/7] net: dsa: mv88e6xxx: drop double ds
 assignment

On Fri, Apr 15, 2016 at 07:21:22PM -0400, Vivien Didelot wrote:
> Every driver assigns ps->ds even though it gets assigned in the shared
> mv88e6xxx_setup_common function. Kill redundancy.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

Thanks
	Andrew

> ---
>  drivers/net/dsa/mv88e6123.c | 2 --
>  drivers/net/dsa/mv88e6131.c | 2 --
>  drivers/net/dsa/mv88e6171.c | 2 --
>  drivers/net/dsa/mv88e6352.c | 2 --
>  4 files changed, 8 deletions(-)
> 
> diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c
> index c34283d..88a812d 100644
> --- a/drivers/net/dsa/mv88e6123.c
> +++ b/drivers/net/dsa/mv88e6123.c
> @@ -76,8 +76,6 @@ static int mv88e6123_setup(struct dsa_switch *ds)
>  	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
>  	int ret;
>  
> -	ps->ds = ds;
> -
>  	ret = mv88e6xxx_setup_common(ds);
>  	if (ret < 0)
>  		return ret;
> diff --git a/drivers/net/dsa/mv88e6131.c b/drivers/net/dsa/mv88e6131.c
> index f5d75fc..6b2bcb0 100644
> --- a/drivers/net/dsa/mv88e6131.c
> +++ b/drivers/net/dsa/mv88e6131.c
> @@ -94,8 +94,6 @@ static int mv88e6131_setup(struct dsa_switch *ds)
>  	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
>  	int ret;
>  
> -	ps->ds = ds;
> -
>  	ret = mv88e6xxx_setup_common(ds);
>  	if (ret < 0)
>  		return ret;
> diff --git a/drivers/net/dsa/mv88e6171.c b/drivers/net/dsa/mv88e6171.c
> index f562250..40222b0 100644
> --- a/drivers/net/dsa/mv88e6171.c
> +++ b/drivers/net/dsa/mv88e6171.c
> @@ -72,8 +72,6 @@ static int mv88e6171_setup(struct dsa_switch *ds)
>  	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
>  	int ret;
>  
> -	ps->ds = ds;
> -
>  	ret = mv88e6xxx_setup_common(ds);
>  	if (ret < 0)
>  		return ret;
> diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c
> index e54ee27..dbd920e 100644
> --- a/drivers/net/dsa/mv88e6352.c
> +++ b/drivers/net/dsa/mv88e6352.c
> @@ -84,8 +84,6 @@ static int mv88e6352_setup(struct dsa_switch *ds)
>  	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
>  	int ret;
>  
> -	ps->ds = ds;
> -
>  	ret = mv88e6xxx_setup_common(ds);
>  	if (ret < 0)
>  		return ret;
> -- 
> 2.8.0
>