netdev - RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN2PR03MB191946453781944A4ABF37BDA0680@SN2PR03MB1919.namprd03.prod.outlook.com>
Date:	Fri, 15 Apr 2016 00:26:20 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Alexander Duyck <alexander.duyck@...il.com>
CC:	"Rustad, Mark D" <mark.d.rustad@...el.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"eli@...lanox.com" <eli@...lanox.com>,
	"jackm@...lanox.com" <jackm@...lanox.com>,
	"yevgenyp@...lanox.com" <yevgenyp@...lanox.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts
 (Hyper-V)



> -----Original Message-----
> From: Alexander Duyck [mailto:alexander.duyck@...il.com]
> Sent: Thursday, April 14, 2016 5:19 PM
> To: KY Srinivasan <kys@...rosoft.com>
> Cc: Rustad, Mark D <mark.d.rustad@...el.com>; David Miller
> <davem@...emloft.net>; netdev <netdev@...r.kernel.org>; linux-
> kernel@...r.kernel.org; devel@...uxdriverproject.org; olaf@...fle.de;
> apw@...onical.com; jasowang@...hat.com; eli@...lanox.com;
> jackm@...lanox.com; yevgenyp@...lanox.com; Ronciak, John
> <john.ronciak@...el.com>; intel-wired-lan@...uxonhyperv.com
> Subject: Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts
> (Hyper-V)
> 
> On Thu, Apr 14, 2016 at 5:11 PM, KY Srinivasan <kys@...rosoft.com> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Rustad, Mark D [mailto:mark.d.rustad@...el.com]
> >> Sent: Thursday, April 14, 2016 5:07 PM
> >> To: KY Srinivasan <kys@...rosoft.com>
> >> Cc: David Miller <davem@...emloft.net>; netdev
> >> <netdev@...r.kernel.org>; linux-kernel@...r.kernel.org;
> >> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> >> jasowang@...hat.com; eli@...lanox.com; jackm@...lanox.com;
> >> yevgenyp@...lanox.com; Ronciak, John <john.ronciak@...el.com>;
> intel-
> >> wired-lan@...uxonhyperv.com
> >> Subject: Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts
> >> (Hyper-V)
> >>
> >> KY Srinivasan <kys@...rosoft.com> wrote:
> >>
> >> >
> >> >
> >> >> -----Original Message-----
> >> >> From: Rustad, Mark D [mailto:mark.d.rustad@...el.com]
> >> >> Sent: Thursday, April 14, 2016 4:01 PM
> >> >> To: KY Srinivasan <kys@...rosoft.com>
> >> >> Cc: David Miller <davem@...emloft.net>; netdev
> >> >> <netdev@...r.kernel.org>; linux-kernel@...r.kernel.org;
> >> >> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> >> >> jasowang@...hat.com; eli@...lanox.com; jackm@...lanox.com;
> >> >> yevgenyp@...lanox.com; Ronciak, John <john.ronciak@...el.com>;
> >> intel-
> >> >> wired-lan@...uxonhyperv.com
> >> >> Subject: Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows
> hosts
> >> >> (Hyper-V)
> >> >>
> >> >> Some comments below:
> >> >
> >> > Mark,
> >> >
> >> > Thank you for the comments. I will address them and repost the
> patches.
> >> >
> >> > Regards,
> >> >
> >> > K. Y
> >>
> >> Please look closely at Alex's comments. I think they are much more
> >> important.
> >
> > I am looking at Alex's comments as I am writing this.
> >
> 
> On additional thought that just occurred to me after looking over the
> other patches you submitted for the hv_netvsc is that you might just
> stub out the multicast, unicast, and vfta configuration calls for the
> hyperV interface since all that stuff should be handled by the other
> link in the bond anyway.  Then you should be able to mostly contain
> all the changes other than the device IDs to the vf.c file which is
> really how this kind of change should work anyway.

I will do that.
> 
> Also I was wondering.  Since HyperV is using a proprietary device ID
> anyway do you really need the calls like the one below?:
> +       if (x86_hyper == &x86_hyper_ms_hyperv) {
> 
> If we can just identify HyperV via the device Id then we could drop
> the x86 arch specific bits and instead just build for all cases.
Yes; I was planning to get rid of the x86 dependency. I will fix this.

K. Y
> 
> - Alex