netdev - Re: [PATCH pci] pci: Add helper function to set VPD size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2016 16:25:22 +0000
From:	Casey Leedom <leedom@...lsio.com>
To:	SWise OGC <swise@...ngridcomputing.com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>
CC:	Hariprasad S <hariprasad@...lsio.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Nirranjan Kirubaharan <nirranjan@...lsio.com>,
	Santosh Rastapur <santosh@...lsio.com>,
	Ariel Elior <ariel.elior@...gic.com>,
	Hannes Reinecke <hare@...e.com>
Subject: Re: [PATCH pci] pci: Add helper function to set VPD size

| From: Steve Wise <swise@...ngridcomputing.com>
| Sent: Friday, April 15, 2016 9:12 AM
|
| On 4/14/2016 1:35 PM, Steve Wise wrote:
| >> The fix is to add a PCI helper function to set the VPD size, so the
| >> driver can expicitly set the exact size of the VPD.
| >>
| >> Fixes commit 104daa71b396 ("PCI: Determine actual VPD size on first
| >> access")
| >>
| >> Signed-off-by: Casey Leedom <leedom@...lsio.com>
| >> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>
| > Looks good!
|
| Hey Bjorn,
|
| Will this make the next 4.6-rc?

  Without a fix of some sort, cxgb4 is completely dead in the water as of the 4.6 series.  I'm also worried about the bnx2x driver which seems to be doing something similar to our cxgb4 driver.  (I.e. there isn't just a single VPD Data Structure hosted at the beginning of the VPD Space.)

Casey