netdev - Re: [PATCH net-next] phy: make some bits preserved while setup forced mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160415.201340.75308332414545478.davem@davemloft.net>
Date:	Fri, 15 Apr 2016 20:13:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	wangweidong1@...wei.com
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, sergei.shtylyov@...entembedded.com,
	andrew@...n.ch
Subject: Re: [PATCH net-next] phy: make some bits preserved while setup
 forced mode

From: Weidong Wang <wangweidong1@...wei.com>
Date: Thu, 14 Apr 2016 15:43:52 +0800

> When tested the PHY SGMII Loopback:
> 1.set the LOOPBACK bit,
> 2.set the autoneg to AUTONEG_DISABLE, it calls the
> genphy_setup_forced which will clear the bit.
> 
> The BMCR_LOOPBACK bit should be preserved.
> 
> As Florian pointed out that other bits should be preserved too.
> So I make the BMCR_ISOLATE and BMCR_PDOWN as well.
> 
> Signed-off-by: Weidong Wang <wangweidong1@...wei.com>

Applied, thank you.