netdev - Re: [net-next PATCH] stmmac: socfpga: remove extra call to socfpga_dwmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160416.214802.155940054393750183.davem@davemloft.net>
Date:	Sat, 16 Apr 2016 21:48:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dinguyen@...nsource.altera.com
Cc:	peppe.cavallaro@...com, dinh.linux@...il.com,
	mgerlach@...nsource.altera.com, netdev@...r.kernel.org
Subject: Re: [net-next PATCH] stmmac: socfpga: remove extra call to
 socfpga_dwmac_setup

From: <dinguyen@...nsource.altera.com>
Date: Thu, 14 Apr 2016 20:42:29 -0500

> From: Dinh Nguyen <dinguyen@...nsource.altera.com>
> 
> In the socfpga_dwmac_probe function, we have a call to socfpga_dwmac_setup,
> which is already called from socfpga_dwmac_init later in the probe function.
> Remove this extra call to socfpga_dwmac_setup.
> 
> Also we should not be calling socfpga_dwmac_setup() directly without wrapping
> it around the proper reset assert/deasserts. That is because the
> socfpga_dwmac_setup() is setting up PHY modes in the system manager, and it
> is requires the EMAC's to be in reset during the PHY setup.
> 
> Reported-by: Matthew Gerlach <mgerlach@...nsource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@...nsource.altera.com>

Applied, thank you.