lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160419143056.GD4876@mwanda> Date: Tue, 19 Apr 2016 17:30:56 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: "David S. Miller" <davem@...emloft.net>, Alexander Duyck <aduyck@...antis.com> Cc: Jesse Gross <jesse@...nel.org>, "John W. Linville" <linville@...driver.com>, Pravin B Shelar <pshelar@...ira.com>, Jiri Benc <jbenc@...hat.com>, Daniel Borkmann <daniel@...earbox.net>, Tom Herbert <tom@...bertland.com>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: [patch -next] geneve: testing the wrong variable in geneve6_build_skb() We intended to test "err" and not "skb". Fixes: aed069df099c ('ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb') Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index efbc7ce..512dbe0 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -733,7 +733,7 @@ static int geneve6_build_skb(struct dst_entry *dst, struct sk_buff *skb, goto free_dst; err = udp_tunnel_handle_offloads(skb, udp_sum); - if (IS_ERR(skb)) + if (err) goto free_dst; gnvh = (struct genevehdr *)__skb_push(skb, sizeof(*gnvh) + opt_len);
Powered by blists - more mailing lists