netdev - Re: [PATCH net-next] net/hsr: Added support for HSR v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Apr 2016 08:21:00 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Peter Heise <mail@...ise.de>
Cc:	arvid.brodin@...en.se, davem@...emloft.net,
	hannes@...essinduktion.org, sd@...asysnail.net, henrik@...tad.us,
	nikolay@...ulusnetworks.com, tgraf@...g.ch, linville@...driver.com,
	gospo@...ulusnetworks.com, dsa@...ulusnetworks.com,
	eranbe@...lanox.com, ast@...mgrid.com, netdev@...r.kernel.org,
	peter.heise@...bus.com
Subject: Re: [PATCH net-next] net/hsr: Added support for HSR v1

On Wed, 13 Apr 2016 13:52:22 +0200
Peter Heise <mail@...ise.de> wrote:

> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 9427f17..bb3a90b 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -773,6 +773,7 @@ enum {
>  	IFLA_HSR_SLAVE1,
>  	IFLA_HSR_SLAVE2,
>  	IFLA_HSR_MULTICAST_SPEC,	/* Last byte of supervision addr */
> +	IFLA_HSR_VERSION,		/* HSR version */
>  	IFLA_HSR_SUPERVISION_ADDR,	/* Supervision frame multicast addr */
>  	IFLA_HSR_SEQ_NR,

You added a new value into the middle of an enumeration field.
This breaks kernel ABI. Older applications (like iproute) would see the wrong
values.

Please submit a new change which moves HSR_VERSION to the end of the enum