lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160419181644.GA40600@kafai-mba.local> Date: Tue, 19 Apr 2016 11:18:02 -0700 From: Martin KaFai Lau <kafai@...com> To: Eric Dumazet <edumazet@...gle.com> CC: Soheil Hassas Yeganeh <soheil@...gle.com>, netdev <netdev@...r.kernel.org>, Neal Cardwell <ncardwell@...gle.com>, Soheil Hassas Yeganeh <soheil.kdev@...il.com>, Willem de Bruijn <willemb@...gle.com>, Yuchung Cheng <ycheng@...gle.com>, Kernel Team <kernel-team@...com> Subject: Re: [RFC PATCH v2 net-next 2/7] tcp: Merge tx_flags/tskey/txstamp_ack in tcp_collapse_retrans On Tue, Apr 19, 2016 at 10:35:52AM -0700, Eric Dumazet wrote: > On Tue, Apr 19, 2016 at 10:28 AM, Martin KaFai Lau <kafai@...com> wrote: > > > A bit off topic, I feel like the SKBTX_ACK_TSTAMP and txstamp_ack are sort > > of redundant but I have not look into the details yet, so not completely > > sure. It wwould be a separate cleanup patch if it is the case. > > Please read 6b084928baac562ed61866f540a96120e9c9ddb7 changelog ;) > > A cache line miss avoidance is critical I looked at the patch but I probably am missing something :( Is checking txstamp_ack alone enough and SKBTX_ACK_TSTAMP is not needed since they are always set together?
Powered by blists - more mailing lists