lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1461032539.10638.143.camel@edumazet-glaptop3.roam.corp.google.com> Date: Mon, 18 Apr 2016 19:22:19 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: David Miller <davem@...emloft.net> Cc: roopa@...ulusnetworks.com, netdev@...r.kernel.org, jhs@...atatu.com, tgraf@...g.ch, nicolas.dichtel@...nd.com Subject: Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats On Mon, 2016-04-18 at 21:48 -0400, David Miller wrote: > > And anyways, I get unaligned accesses without Roopa's changes :-/ > > davem@...ience:~$ ip l l > [3391066.656729] Kernel unaligned access at TPC[7d6c14] loopback_get_stats64+0x74/0xa0 > [3391066.672020] Kernel unaligned access at TPC[7d6c18] loopback_get_stats64+0x78/0xa0 > [3391066.687282] Kernel unaligned access at TPC[7d6c1c] loopback_get_stats64+0x7c/0xa0 > [3391066.702573] Kernel unaligned access at TPC[7d6c20] loopback_get_stats64+0x80/0xa0 > [3391066.717858] Kernel unaligned access at TPC[8609dc] dev_get_stats+0x3c/0xe0 Yes, rtnl_fill_stats() probably has the same mistake. commit 550bce59baf3f3059cd4ae1e268f08f2d2cb1d5c Author: Roopa Prabhu <roopa@...ulusnetworks.com> Date: Fri Apr 15 20:36:25 2016 -0700 rtnetlink: rtnl_fill_stats: avoid an unnecssary stats copy This patch passes netlink attr data ptr directly to dev_get_stats thus elimiating a stats copy. Suggested-by: David Miller <davem@...emloft.net> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com> Signed-off-by: David S. Miller <davem@...emloft.net>
Powered by blists - more mailing lists