lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1461069286-31946-1-git-send-email-dvlasenk@redhat.com> Date: Tue, 19 Apr 2016 14:34:44 +0200 From: Denys Vlasenko <dvlasenk@...hat.com> To: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Cc: Denys Vlasenko <dvlasenk@...hat.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Shannon Nelson <shannon.nelson@...el.com>, Carolyn Wyborny <carolyn.wyborny@...el.com>, Don Skidmore <donald.c.skidmore@...el.com>, Bruce Allan <bruce.w.allan@...el.com>, John Ronciak <john.ronciak@...el.com>, Mitch Williams <mitch.a.williams@...el.com>, "David S. Miller" <davem@...emloft.net>, LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org Subject: [PATCH 1/3] e1000e: e1000e_cyclecounter_read(): incvalue is 32 bits, not 64 "incvalue" variable holds a result of "er32(TIMINCA) & E1000_TIMINCA_INCVALUE_MASK" and used in "do_div(temp, incvalue)" as a divisor. Thus, "u64 incvalue" declaration is probably a mistake. Even though it seems to be a harmless one, let's fix it. Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com> CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com> CC: Jesse Brandeburg <jesse.brandeburg@...el.com> CC: Shannon Nelson <shannon.nelson@...el.com> CC: Carolyn Wyborny <carolyn.wyborny@...el.com> CC: Don Skidmore <donald.c.skidmore@...el.com> CC: Bruce Allan <bruce.w.allan@...el.com> CC: John Ronciak <john.ronciak@...el.com> CC: Mitch Williams <mitch.a.williams@...el.com> CC: David S. Miller <davem@...emloft.net> CC: LKML <linux-kernel@...r.kernel.org> CC: netdev@...r.kernel.org --- drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 9b4ec13..967311b 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -4300,7 +4300,8 @@ static cycle_t e1000e_cyclecounter_read(const struct cyclecounter *cc) } if ((hw->mac.type == e1000_82574) || (hw->mac.type == e1000_82583)) { - u64 incvalue, time_delta, rem, temp; + u64 time_delta, rem, temp; + u32 incvalue; int i; /* errata for 82574/82583 possible bad bits read from SYSTIMH/L -- 1.8.1.4
Powered by blists - more mailing lists