netdev - RE: [PATCH 5/5] drivers/net: support hdlc function for QE-UCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM3PR04MB11852D3C68F35C92CC344B98916D0@AM3PR04MB1185.eurprd04.prod.outlook.com>
Date:	Wed, 20 Apr 2016 02:28:08 +0000
From:	Qiang Zhao <qiang.zhao@....com>
To:	Christophe Leroy <christophe.leroy@....fr>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Xiaobo Xie <xiaobo.xie@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"oss@...error.net" <oss@...error.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: RE: [PATCH 5/5] drivers/net: support hdlc function for QE-UCC

On 20/04/2016 12:22AM, Christophe Leroy <christophe.leroy@....fr> wrote
> -----Original Message-----
> From: Christophe Leroy [mailto:christophe.leroy@....fr]
> Sent: Wednesday, April 20, 2016 12:22 AM
> To: Qiang Zhao <qiang.zhao@....com>; davem@...emloft.net
> Cc: gregkh@...uxfoundation.org; Xiaobo Xie <xiaobo.xie@....com>; linux-
> kernel@...r.kernel.org; oss@...error.net; netdev@...r.kernel.org;
> akpm@...ux-foundation.org; linuxppc-dev@...ts.ozlabs.org
> Subject: Re: [PATCH 5/5] drivers/net: support hdlc function for QE-UCC
> 
> Le 30/03/2016 10:50, Zhao Qiang a écrit :
> > The driver add hdlc support for Freescale QUICC Engine.
> > It support NMSI and TSA mode.
> When using TSA, how does the TSA gets configured ? Especially how do you
> describe which Timeslot is switched to HDLC channels ?

the TSA is configured statically according to device tree node. 
For " which Timeslot is switched to HDLC channels ", there is a property 
"fsl,tx-timeslot-mask" in device tree to describe it.

> Is it possible to route some Timeslots to one UCC for HDLC, and route some
> others to another UCC for an ALSA sound driver ?

The feature you describe is not supported at present.

> The QE also have a QMC which allows to split all timeslots to a given UCC into
> independant channels that can either be used with HDLC or transparents (for
> audio for instance). Do you intent to also support QMC ?

new QE use UMCC instead of QMC in old QE, we have started to develop UMCC.
 
> According to the compatible property, it looks like your driver is for freescale
> T1040. The MPC83xx also has a Quick Engine, would it work on it too ?

The driver is common, but tested on t1040, it is needed to add node to MPC83xx
If you want to test on mpc83xx.

-Zhao Qiang