netdev - AW: [PATCH net-next] net/hsr: Added support for HSR v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <28805_1461136234_57172B6A_28805_14792_1_01b784c4ce1945e28da3d3dd423a56a9@DE0-03DAG07-P04.central.mail.corp>
Date:	Wed, 20 Apr 2016 07:10:28 +0000
From:	"Heise, Peter" <peter.heise@...bus.com>
To:	David Miller <davem@...emloft.net>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>
CC:	"arvid.brodin@...en.se" <arvid.brodin@...en.se>,
	"hannes@...essinduktion.org" <hannes@...essinduktion.org>,
	"sd@...asysnail.net" <sd@...asysnail.net>,
	"henrik@...tad.us" <henrik@...tad.us>,
	"nikolay@...ulusnetworks.com" <nikolay@...ulusnetworks.com>,
	"tgraf@...g.ch" <tgraf@...g.ch>,
	"linville@...driver.com" <linville@...driver.com>,
	"gospo@...ulusnetworks.com" <gospo@...ulusnetworks.com>,
	"dsa@...ulusnetworks.com" <dsa@...ulusnetworks.com>,
	"eranbe@...lanox.com" <eranbe@...lanox.com>,
	"ast@...mgrid.com" <ast@...mgrid.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: AW: [PATCH net-next] net/hsr: Added support for HSR v1

Thanks for the advice Stephen, new patch submitted!


-----Ursprüngliche Nachricht-----
Von: David Miller [mailto:davem@...emloft.net] 
Gesendet: Dienstag, 19. April 2016 18:12
An: stephen@...workplumber.org
Cc: mail@...ise.de; arvid.brodin@...en.se; hannes@...essinduktion.org; sd@...asysnail.net; henrik@...tad.us; nikolay@...ulusnetworks.com; tgraf@...g.ch; linville@...driver.com; gospo@...ulusnetworks.com; dsa@...ulusnetworks.com; eranbe@...lanox.com; ast@...mgrid.com; netdev@...r.kernel.org; Heise, Peter
Betreff: Re: [PATCH net-next] net/hsr: Added support for HSR v1

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Tue, 19 Apr 2016 08:21:00 -0700

> On Wed, 13 Apr 2016 13:52:22 +0200
> Peter Heise <mail@...ise.de> wrote:
> 
>> diff --git a/include/uapi/linux/if_link.h 
>> b/include/uapi/linux/if_link.h index 9427f17..bb3a90b 100644
>> --- a/include/uapi/linux/if_link.h
>> +++ b/include/uapi/linux/if_link.h
>> @@ -773,6 +773,7 @@ enum {
>>  	IFLA_HSR_SLAVE1,
>>  	IFLA_HSR_SLAVE2,
>>  	IFLA_HSR_MULTICAST_SPEC,	/* Last byte of supervision addr */
>> +	IFLA_HSR_VERSION,		/* HSR version */
>>  	IFLA_HSR_SUPERVISION_ADDR,	/* Supervision frame multicast addr */
>>  	IFLA_HSR_SEQ_NR,
> 
> You added a new value into the middle of an enumeration field.
> This breaks kernel ABI. Older applications (like iproute) would see 
> the wrong values.
> 
> Please submit a new change which moves HSR_VERSION to the end of the 
> enum

Good catch, Stephen.

This mail has originated outside your organization, either from an external partner or the Global Internet.
Keep this in mind if you answer this message.



The information in this e-mail is confidential. The contents may not be disclosed or used by anyone other than the addressee. Access to this e-mail by anyone else is unauthorised.
If you are not the intended recipient, please notify Airbus immediately and delete this e-mail.
Airbus cannot accept any responsibility for the accuracy or completeness of this e-mail as it has been sent over public networks. If you have any concerns over the content of this message or its Accuracy or Integrity, please contact Airbus immediately.
All outgoing e-mails from Airbus are checked using regularly updated virus scanning software but you should take whatever measures you deem to be appropriate to ensure that this message and any attachments are virus free.