netdev - Re: skb_at_tc_ingress helper breaks compilation of oot modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160420105354.GA12348@pinguin.zoo>
Date:	Wed, 20 Apr 2016 12:53:54 +0200
From:	Ingo Saitz <ingo@...d.uni-hannover.de>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	Ingo Saitz <ingo@...d.uni-hannover.de>, netdev@...r.kernel.org
Subject: Re: skb_at_tc_ingress helper breaks compilation of oot modules

On Wed, Apr 20, 2016 at 12:38:11PM +0200, Daniel Borkmann wrote:
> Hmm, your fail.c test case only contains '#include <net/ipv6.h>'?

No, only when building oot modules (virtualbox, and I found batman-adv
having the same issue), so I reduced it to the most simple test case. This
actually builds a fail.ko on 4.4.7 with CONFIG_NET_CLS_ACT=y without
errors.

> Note, upstream kernel never cared about out-of-tree modules, only
> in-tree code. ;) Did you run into an issue with any in-tree code?

A current fix for oot modules would be to add:

#include <uapi/linux/pkt_cls.h>

in front of that include for kernel >= 4.5…

    Ingo
-- 
Kennedy's Lemma:
    If you can parse Perl, you can solve the Halting Problem.

http://www.perlmonks.org/?node_id=663393