netdev - Re: [PATCH] net: phy: spi_ks8895: Don't leak references to SPI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160421.150039.591459586047228776.davem@davemloft.net>
Date:	Thu, 21 Apr 2016 15:00:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	broonie@...nel.org
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: spi_ks8895: Don't leak references to SPI
 devices

From: Mark Brown <broonie@...nel.org>
Date: Wed, 20 Apr 2016 12:54:05 +0100

> The ks8895 driver is using spi_dev_get() apparently just to take a copy
> of the SPI device used to instantiate it but never calls spi_dev_put()
> to free it.  Since the device is guaranteed to exist between probe() and
> remove() there should be no need for the driver to take an extra
> reference to it so fix the leak by just using a straight assignment.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>

Applied.