netdev - Re: [PATCH net] atl2: Disable unimplemented scatter/gather feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160421.151248.1066170820995763060.davem@davemloft.net>
Date:	Thu, 21 Apr 2016 15:12:48 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	netdev@...r.kernel.org, jyackoski@...pto-nite.com
Subject: Re: [PATCH net] atl2: Disable unimplemented scatter/gather feature

From: Ben Hutchings <ben@...adent.org.uk>
Date: Wed, 20 Apr 2016 23:23:08 +0100

> atl2 includes NETIF_F_SG in hw_features even though it has no support
> for non-linear skbs.  This bug was originally harmless since the
> driver does not claim to implement checksum offload and that used to
> be a requirement for SG.
> 
> Now that SG and checksum offload are independent features, if you
> explicitly enable SG *and* use one of the rare protocols that can use
> SG without checkusm offload, this potentially leaks sensitive
> information (before you notice that it just isn't working).  Therefore
> this obscure bug has been designated CVE-2016-2117.
> 
> Reported-by: Justin Yackoski <jyackoski@...pto-nite.com>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> Fixes: ec5f06156423 ("net: Kill link between CSUM and SG features.")

Applied and queued up for -stable, thanks.