netdev - Re: [PATCH net] openvswitch: use flow protocol when recalculating ipv6 checksums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160421.152940.728927694990381481.davem@davemloft.net>
Date:	Thu, 21 Apr 2016 15:29:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	simon.horman@...ronome.com
Cc:	pshelar@....org, jesse@...nel.org, netdev@...r.kernel.org,
	dev@...nvswitch.org, jrajahalme@...ira.com
Subject: Re: [PATCH net] openvswitch: use flow protocol when recalculating
 ipv6 checksums

From: Simon Horman <simon.horman@...ronome.com>
Date: Thu, 21 Apr 2016 11:49:15 +1000

> When using masked actions the ipv6_proto field of an action
> to set IPv6 fields may be zero rather than the prevailing protocol
> which will result in skipping checksum recalculation.
> 
> This patch resolves the problem by relying on the protocol
> in the flow key rather than that in the set field action.
> 
> Fixes: 83d2b9ba1abc ("net: openvswitch: Support masked set actions.")
> Cc: Jarno Rajahalme <jrajahalme@...ira.com>
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>

Looks good to me, applied and queued up for -stable.

Thanks Simon.