netdev - Re: [PATCH net-next 04/10] net: hns: add attribute reset-field-offset for dsaf node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <571AD2CE.4020905@huawei.com>
Date:	Sat, 23 Apr 2016 09:41:34 +0800
From:	Yisen Zhuang <Yisen.zhuang@...wei.com>
To:	Rob Herring <robh@...nel.org>
CC:	<devicetree@...r.kernel.org>, <netdev@...r.kernel.org>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<davem@...emloft.net>, <yankejian@...wei.com>,
	<huangdaode@...ilicon.com>, <salil.mehta@...wei.com>,
	<lipeng321@...wei.com>, <liguozhu@...wei.com>,
	<xieqianqian@...wei.com>, <linuxarm@...wei.com>
Subject: Re: [PATCH net-next 04/10] net: hns: add attribute reset-field-offset
 for dsaf node

Hi Rob,

Thanks for your suggestion. I will put DT bindings in separate patches,
and modify related dts file in next version.

Thanks,

Yisen

在 2016/4/23 4:44, Rob Herring 写道:
> On Fri, Apr 22, 2016 at 03:20:13PM +0800, Yisen Zhuang wrote:
>> Add the subctrl reset offset for dsaf, this property is used to reset
>> xge/ge ports for different dsaf. If this attribute is not present,
>> default value 0 will be used.
>>
>> Signed-off-by: Daode Huang <huangdaode@...ilicon.com>
>> Signed-off-by: Yisen Zhuang <yisen.zhuang@...wei.com>
>> ---
>>  .../devicetree/bindings/net/hisilicon-hns-dsaf.txt |  2 ++
> 
> Please put DT bindings in separate patches and don't modify the same 
> binding in a series of patches. You are describing h/w and the h/w is 
> not changing.
> 
>>  drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c |  8 +++++
>>  drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h |  1 +
>>  drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 40 +++++++++++++++-------
>>  4 files changed, 39 insertions(+), 12 deletions(-)
> 
> .
>