netdev - Re: [PATCH net-next] route: move lwtunnel state to a single place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Apr 2016 16:20:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, lrichard@...hat.com
Subject: Re: [PATCH net-next] route: move lwtunnel state to a single place

From: Jiri Benc <jbenc@...hat.com>
Date: Fri, 22 Apr 2016 12:40:02 +0200

> Commit 751a587ac9f9 ("route: fix breakage after moving lwtunnel state")
> moved lwtstate to the end of dst_entry for 32bit archs. This makes it share
> the cacheline with __refcnt which had an unkown effect on performance. For
> this reason, the pointer was kept in place for 64bit archs.
> 
> However, later performance measurements showed this is of no concern. It
> turns out that every performance sensitive path that accesses lwtstate
> accesses also struct rtable or struct rt6_info which share the same cache
> line.
> 
> Thus, to get rid of a few #ifdefs, move the field to the end of the struct
> also for 64bit.
> 
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Fair enough, applied, thanks Jiri.