[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <571E9A8A.50808@cumulusnetworks.com>
Date: Mon, 25 Apr 2016 15:30:34 -0700
From: Roopa Prabhu <roopa@...ulusnetworks.com>
To: David Miller <davem@...emloft.net>
CC: dsa@...ulusnetworks.com, netdev@...r.kernel.org,
mmanning@...cade.com
Subject: Re: [PATCH] net: ipv6: Delete host routes on an ifdown
On 4/25/16, 1:42 PM, David Miller wrote:
> From: David Ahern <dsa@...ulusnetworks.com>
> Date: Mon, 25 Apr 2016 13:40:26 -0600
>
>> It's unfortunate you want to take that action. Last week I came across
>> a prior attempt by Stephen to do this same thing -- keep IPv6
>> addresses. That prior attempt was reverted by commit
>> 73a8bd74e261. Cumulus, Brocade, and others clearly want this
>> capability.
> But nobody has implemented it correctly, it doesn't matter who wants
> the feature. That's why it keeps getting reverted.
>
> Also, this testing you are talking about should have happened long
> before you submitted that first patch that introduced all of these
> regressions. My observations tell me that the bulk of the testing
> happened afterwards and that's why all the regressions are popping up
> now.
sorry if it seems that way. But we have been testing several versions of this patch
internally. davidA has been throwing it at all of our internal tests just to make sure
it gets all the testing it needs before 4.6 goes out. This last fix was something
that I think got introduced in one of the later versions during re-implementing
bits of it based on feedback. And one of our new recent tests under stress
caught it and we rushed the fix out.
thanks,
Roopa
Powered by blists - more mailing lists