netdev - Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <571FB289.40807@cogentembedded.com>
Date:	Tue, 26 Apr 2016 21:25:13 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

Hello.

On 04/26/2016 01:24 PM, Nicolas Ferre wrote:

> Fix gpio active flag for the phy reset-gpios property. The line is
> active low instead of active high.
> Actually, this flags was never used by the macb driver.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: David Miller <davem@...emloft.net>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
> ---
> Hi,
>
> Thanks for having reported this bug to me.

    And thank you for beating me to it and doing the patch. I'm still busy 
with other stuff. :-(

> I hope that we will be able to move forward for changing the phy
> reset code in the macb driver.

    I meant to delete it entirely.

> I plan to queue this patch through arm-soc for 4.7.

    Hm, that way we get that board broken if my phylib/macb patches get merged 
before your patch. Perhaps it would be better to merge this patch thru DaveM's 
tree (before my patches) to keep the kernel bisectable?

> Thanks, best regards,
>    Nicolas

MBR, Sergei