netdev - Re: [PATCH net-next V1 00/11] Mellanox 100G extending mlx5 ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160426.174150.2239494413467110.davem@davemloft.net>
Date:	Tue, 26 Apr 2016 17:41:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	saeedm@....mellanox.co.il
Cc:	saeedm@...lanox.com, netdev@...r.kernel.org, ogerlitz@...lanox.com,
	talal@...lanox.com, eranbe@...lanox.com
Subject: Re: [PATCH net-next V1 00/11] Mellanox 100G extending mlx5 ethtool
 support

From: Saeed Mahameed <saeedm@....mellanox.co.il>
Date: Tue, 26 Apr 2016 23:55:03 +0300

> It will be a nightmare to rollback in such case.  What if the rollback failed ?

It is absolutely essential to handle this properly.

Which means you must have a prepare/commit model, wherein the prepare
phase makes sure to pre-allocate all necessary resources, and only if
all the prepare phase preparations succeed will the commit phase run.

The commit phase cannot error, because all of the resources have been
allocated successfully already.

This way there are no issues of "rolling back" because you never
actually move the state forward until you can guarantee that you can
do everything.