netdev - Re: [PATCH net-next] net-rfs: fix false sharing accessing sd->input_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALx6S34-mbnBJcMvdZd869-dvgygkygMAZ6dNCKgGCt7atGbJA@mail.gmail.com>
Date:	Tue, 26 Apr 2016 15:55:27 -0700
From:	Tom Herbert <tom@...bertland.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net-rfs: fix false sharing accessing sd->input_queue_head

On Tue, Apr 26, 2016 at 3:30 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> sd->input_queue_head is incremented for each processed packet
> in process_backlog(), and read from other cpus performing
> Out Of Order avoidance in get_rps_cpu()
>
> Moving this field in a separate cache line keeps it mostly
> hot for the cpu in process_backlog(), as other cpus will
> only read it.
>
> In a stress test, process_backlog() was consuming 6.80 % of cpu cycles,
> and the patch reduced the cost to 0.65 %
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Very nice!

Acked-by: Tom Herbert <tom@...bertland.com>

> ---
>  include/linux/netdevice.h |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 18d8394f2e5d..934ca866562d 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2747,11 +2747,15 @@ struct softnet_data {
>         struct sk_buff          *completion_queue;
>
>  #ifdef CONFIG_RPS
> -       /* Elements below can be accessed between CPUs for RPS */
> +       /* input_queue_head should be written by cpu owning this struct,
> +        * and only read by other cpus. Worth using a cache line.
> +        */
> +       unsigned int            input_queue_head ____cacheline_aligned_in_smp;
> +
> +       /* Elements below can be accessed between CPUs for RPS/RFS */
>         struct call_single_data csd ____cacheline_aligned_in_smp;
>         struct softnet_data     *rps_ipi_next;
>         unsigned int            cpu;
> -       unsigned int            input_queue_head;
>         unsigned int            input_queue_tail;
>  #endif
>         unsigned int            dropped;
>
>