netdev - Re: [PATCH] net: dsa: mv88e6xxx: fix uninitialized error return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wpnlmab1.fsf@ketchup.mtl.sfl>
Date:	Mon, 25 Apr 2016 21:24:34 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Colin King <colin.king@...onical.com>,
	"David S . Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix uninitialized error return

Hi Colin,

Colin King <colin.king@...onical.com> writes:

> From: Colin Ian King <colin.king@...onical.com>
>
> The error return err is not initialized and there is a possibility
> that err is not assigned causing mv88e6xxx_port_bridge_join to
> return a garbage error return status. Fix this by initializing err
> to 0.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Even though that cannot happen, the fix doesn't hurt.
Adding Geert in the loop who submitted an RFC for this first:

    https://lkml.org/lkml/2016/4/25/95

Thanks,

        Vivien