netdev - Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Apr 2016 14:37:07 +0200
From:	Jan Kara <jack@...e.cz>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	Jan Kara <jack@...e.cz>, netdev@...r.kernel.org,
	davem@...emloft.net, sd@...asysnail.net, johannes@...solutions.net,
	kvalo@...eaurora.org, linux-wireless@...r.kernel.org,
	jack@...e.com, linux-kernel@...r.kernel.org, pshelar@...ira.com,
	dev@...nvswitch.org, jhs@...atatu.com, philipp.reisner@...bit.com,
	lars.ellenberg@...bit.com, drbd-dev@...ts.linbit.com
Subject: Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit()

On Tue 26-04-16 14:31:58, Nicolas Dichtel wrote:
> Le 26/04/2016 13:08, Jan Kara a écrit :
> > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote:
> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> > 
> > OK, so I somewhat miss a description of what will this do to the netlink
> > message so that I can judge whether the change is fine for the userspace
> > counterpart parsing these messages. AFAIU this changes the message format
> > by adding a QUOTA_NL_A_PAD field before each 64-bit field which needs an
> > alignment, am I guessing right? Thus when the userspace counterpart uses
> > genlmsg_parse() it should just silently ignore these attributes if I read
> > the documentation right. Did I understand this correctly?
> Yes, that's it.

OK, then feel free to add:

Acked-by: Jan Kara <jack@...e.cz>

to the quota patch.

								Honza

-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR